Skip to content

Conversation

@dhensle
Copy link
Contributor

@dhensle dhensle commented Nov 13, 2025

Fix for #846.

In addition to CI tests, also successfully ran the SANDAG (cropped) estimation data through estimation mode and confirmed the creation of school escorting and joint tour frequency and composition EDBs.

@dhensle dhensle marked this pull request as draft November 13, 2025 18:02
@dhensle dhensle marked this pull request as ready for review November 13, 2025 18:15
@jpn-- jpn-- added this to Phase 11 Nov 13, 2025
@jpn-- jpn-- moved this to Tasked in Phase 11 Nov 13, 2025
@jpn-- jpn-- self-requested a review November 13, 2025 18:33
@jpn--
Copy link
Member

jpn-- commented Dec 2, 2025

This looks fine to me. @dhensle Just one (new) thing to do: please add a section to docs/dev-guide/changes.md about this change, under the Upcoming Changes section at the top.

@jpn-- jpn-- moved this from Tasked to Under Review in Phase 11 Dec 2, 2025
@dhensle dhensle self-assigned this Dec 2, 2025
@dhensle
Copy link
Contributor Author

dhensle commented Dec 16, 2025

@jpn-- I have update the change log for your review. Also, I tried to repair the progressive mtc test by unzipping, changing the Alt column name to alt in the school escorting bundle that was failing, and re-zipped it back up, but now I am getting some weird error about not finding the input checker log. Is there something different you do to create the zip file that maybe I messed up?

@jpn--
Copy link
Member

jpn-- commented Dec 18, 2025

@dhensle Typically when I need to regenerate the progressive tests it's because the numbers have changed slightly, so I just delete the regression targets and re-run, which should automatically regenerate the files. But for a change like this where the numbers are all the same and it's just a header that's changed, what you describe should work -- and I'm surprised it didn't.

@jpn-- jpn-- merged commit 6266ce4 into ActivitySim:main Jan 8, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Under Review to Done in Phase 11 Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants